Skip to content
  • Pavan Naik's avatar
    ae7079af
    BUG#24806257 : MTR DOESN'T DO CHECK-TESTCASE IF THERE IS --SKIP IN TEST · ae7079af
    Pavan Naik authored
    
    
    Description :
    =============
    Skip statements should be placed in the beginning of a test before it
    creates tables and other objects. If a test is skipped after altering
    the database state then it might affect the subsequent test runs on
    the same thread. `check-testcase` is run only if a test run is
    completed successfully and not run when a test gets skipped. This is a
    badly written test and will be better if it fails and gets noticed in PB2.
    
    E.g :
    -----
    CREATE TABLE t1(a INT);
    skip "Intentional skip doesn't complain about existing table t1";
    DROP TABLE t1;
    
    Here, MTR should have complained about existing table t1.
    
    Fix :
    =====
    MTR is modified to run check-testcase after a test gets skipped.
    Tests modifying the system state before the skip will now fail with
    check-testcase failure and get noticed in regression runs.
    
    Reviewed-by: default avatarAnitha Gopi <anitha.gopi@oracle.com>
    Reviewed-by: default avatarDeepa Dixit <deepa.dixit@oracle.com>
    RB: 14835
    ae7079af
    BUG#24806257 : MTR DOESN'T DO CHECK-TESTCASE IF THERE IS --SKIP IN TEST
    Pavan Naik authored
    
    
    Description :
    =============
    Skip statements should be placed in the beginning of a test before it
    creates tables and other objects. If a test is skipped after altering
    the database state then it might affect the subsequent test runs on
    the same thread. `check-testcase` is run only if a test run is
    completed successfully and not run when a test gets skipped. This is a
    badly written test and will be better if it fails and gets noticed in PB2.
    
    E.g :
    -----
    CREATE TABLE t1(a INT);
    skip "Intentional skip doesn't complain about existing table t1";
    DROP TABLE t1;
    
    Here, MTR should have complained about existing table t1.
    
    Fix :
    =====
    MTR is modified to run check-testcase after a test gets skipped.
    Tests modifying the system state before the skip will now fail with
    check-testcase failure and get noticed in regression runs.
    
    Reviewed-by: default avatarAnitha Gopi <anitha.gopi@oracle.com>
    Reviewed-by: default avatarDeepa Dixit <deepa.dixit@oracle.com>
    RB: 14835
Loading