Skip to content
  • Tor Didriksen's avatar
    dd4d3eb6
    Bug #25917702: USE C++11 THREAD-LOCAL STORAGE INSTEAD OF MY_THREAD_LOCAL · dd4d3eb6
    Tor Didriksen authored
    Followup patch: innodb_zip.wl5522_debug_zip fails on windows.
    
    fil_tablespace_iterate() does:
    
    file = os_file_create_simple_no_error_handling(... &success)
    DBUG_EXECUTE_IF(....)
    if (!success) {
       /* The following call prints an error message */
       os_file_get_last_error(true);
    }
    
    Before the patch:
    os_file_get_last_error_low() does GetLastError() which returns zero,
    because there are intervening system calls (in the implementation of
    DBUG_EXECUTE_IF) which do not fail.
    
    After the patch:
    os_file_get_last_error_low() does GetLastError() which returns 32,
    since there are no more intervening system calls. So we get a couple
    of more warnings.
    
    Fix: add suppressions for new warnings.
    
    Also: remove unused function ut_rnd_set_seed()
    dd4d3eb6
    Bug #25917702: USE C++11 THREAD-LOCAL STORAGE INSTEAD OF MY_THREAD_LOCAL
    Tor Didriksen authored
    Followup patch: innodb_zip.wl5522_debug_zip fails on windows.
    
    fil_tablespace_iterate() does:
    
    file = os_file_create_simple_no_error_handling(... &success)
    DBUG_EXECUTE_IF(....)
    if (!success) {
       /* The following call prints an error message */
       os_file_get_last_error(true);
    }
    
    Before the patch:
    os_file_get_last_error_low() does GetLastError() which returns zero,
    because there are intervening system calls (in the implementation of
    DBUG_EXECUTE_IF) which do not fail.
    
    After the patch:
    os_file_get_last_error_low() does GetLastError() which returns 32,
    since there are no more intervening system calls. So we get a couple
    of more warnings.
    
    Fix: add suppressions for new warnings.
    
    Also: remove unused function ut_rnd_set_seed()
Loading