Skip to content
  • Marc Alff's avatar
    e7808b18
    Bug#21223458 UPDATE TO SETUP_CONSUMERS DOES NOT UPDATE CLIENT HISTORY · e7808b18
    Marc Alff authored
    LOGGING FLAG
    
    Before this fix,
      UPDATE performance_schema.setup_consumers
    when changing the consumers for history / history_long events,
    has no effect on threads already running.
    
    Disabling a consumer did not stop event collection for running threads.
    
    Enabling a consumer did not start event collection for running threads.
    
    Only threads connected after the update would function properly.
    
    The root cause is that some derived flags per thread,
    like pfs_instr::m_flag_events_waits_history,
    were not re-evaluated.
    
    The root cause is the definition of the history consumers,
    for which the flag row_setup_consumers::m_thread_refresh
    was not set.
    
    This fix sets row_setup_consumers::m_thread_refresh to true
    for the history consumers, so that per thread derived flags are
    re evaluated when a consumer is updated.
    e7808b18
    Bug#21223458 UPDATE TO SETUP_CONSUMERS DOES NOT UPDATE CLIENT HISTORY
    Marc Alff authored
    LOGGING FLAG
    
    Before this fix,
      UPDATE performance_schema.setup_consumers
    when changing the consumers for history / history_long events,
    has no effect on threads already running.
    
    Disabling a consumer did not stop event collection for running threads.
    
    Enabling a consumer did not start event collection for running threads.
    
    Only threads connected after the update would function properly.
    
    The root cause is that some derived flags per thread,
    like pfs_instr::m_flag_events_waits_history,
    were not re-evaluated.
    
    The root cause is the definition of the history consumers,
    for which the flag row_setup_consumers::m_thread_refresh
    was not set.
    
    This fix sets row_setup_consumers::m_thread_refresh to true
    for the history consumers, so that per thread derived flags are
    re evaluated when a consumer is updated.
Loading