Skip to content
  • Tatiana Azundris Nuernberg's avatar
    c7154cf2
    Bug#27462408: IMPROPER ERROR LOG MESSAGES LOGGED USING VA_REPORT() IN SQL/RPL_REPORTING.CC · c7154cf2
    Tatiana Azundris Nuernberg authored
    - Moves certain error-messages from the client into the server range,
      and vice versa
    
    - Updates .test / .result files accordingly
    
    - Adds new constant, ER_SERVER_RANGE_START, for range-checks / asserts
    
    - Original ticket highlighted the lack of clarity of our overlapping
      error ranges (OS errno and our "global errors" from mysys/error.cc
      both live in the range starting at 0). Patch updates the perror tool
      so both are shown where applicable and conducive to clarity; the
      mysys messages are clarified and aligned with our use in error-logging,
      where errno/Error are used for OS error numbers, and error-code/errcode
      are used for MySQL ones.
    
    - Updated some messages to contain more pertinent information (e.g.
      original error-code when wrapping the message in a new one, like
      in "from-diagnostics-area" cases.
    
    - Split several uses of ME_ERRORLOG ("send this to both the client,
      and the error-log") into two separate calls, one for error-logging,
      one for the client, so two different error-codes may be used.
    
    - Add "MY-" prefix to certain error messages that were lacking it.
    
    - Update replication code to use server-range error-codes when
      error-logging.
    
    - Update MAX_SLAVE_ERROR now that we have a fair number of high index
      error codes.
    c7154cf2
    Bug#27462408: IMPROPER ERROR LOG MESSAGES LOGGED USING VA_REPORT() IN SQL/RPL_REPORTING.CC
    Tatiana Azundris Nuernberg authored
    - Moves certain error-messages from the client into the server range,
      and vice versa
    
    - Updates .test / .result files accordingly
    
    - Adds new constant, ER_SERVER_RANGE_START, for range-checks / asserts
    
    - Original ticket highlighted the lack of clarity of our overlapping
      error ranges (OS errno and our "global errors" from mysys/error.cc
      both live in the range starting at 0). Patch updates the perror tool
      so both are shown where applicable and conducive to clarity; the
      mysys messages are clarified and aligned with our use in error-logging,
      where errno/Error are used for OS error numbers, and error-code/errcode
      are used for MySQL ones.
    
    - Updated some messages to contain more pertinent information (e.g.
      original error-code when wrapping the message in a new one, like
      in "from-diagnostics-area" cases.
    
    - Split several uses of ME_ERRORLOG ("send this to both the client,
      and the error-log") into two separate calls, one for error-logging,
      one for the client, so two different error-codes may be used.
    
    - Add "MY-" prefix to certain error messages that were lacking it.
    
    - Update replication code to use server-range error-codes when
      error-logging.
    
    - Update MAX_SLAVE_ERROR now that we have a fair number of high index
      error codes.
Loading