Skip to content
  • Tor Didriksen's avatar
    4de4f0de
    Bug #30035089 CLANG-TIDY ON THE CMAKE CODEBASE [noclose] · 4de4f0de
    Tor Didriksen authored
    Manual cleanup of cmake code for ndbcluster:
    
    CMake Warning (dev) at storage/ndb/ndb_configure.cmake:310 (SET):
      implicitly converting 'INTEGER' to 'STRING' type.
    
    Check all usage of MYSQL_ADD_EXECUTABLE() and ADD_CONVENIENCE_LIBRARY()/
    Use macro options for these utilities, rather than separate calls to
    TARGET_LINK_LIBRARIES()
    
    Cosmetics, indentation, sorting of lists etc. in files touched by the above.
    
    Set interface multiplicity on the 'ndbgeneral' library, so that linking
    of executables are not dependent on the order of libraries linked.
    
    Limit memory used by javac. Pushbuild showed several of these in parallel:
    pb2user  54281  0.3  0.0 40029084 71080 pts/1  Sl   13:15   0:06 /usr/local/java/jdk1.8-64/bin/javac
    and the build failed.
    
    Remove a simple FILE(GLOB ...) which had only one result.
    With globbing cmake cannot track dependencies, and dependent targets
    are not rebuilt when source input changes.
    
    TODO: remove all the other globbing in use to find .java sources.
    
    Change-Id: I6ea4a8c8c094ab629b904d1fb44002827641f6b9
    4de4f0de
    Bug #30035089 CLANG-TIDY ON THE CMAKE CODEBASE [noclose]
    Tor Didriksen authored
    Manual cleanup of cmake code for ndbcluster:
    
    CMake Warning (dev) at storage/ndb/ndb_configure.cmake:310 (SET):
      implicitly converting 'INTEGER' to 'STRING' type.
    
    Check all usage of MYSQL_ADD_EXECUTABLE() and ADD_CONVENIENCE_LIBRARY()/
    Use macro options for these utilities, rather than separate calls to
    TARGET_LINK_LIBRARIES()
    
    Cosmetics, indentation, sorting of lists etc. in files touched by the above.
    
    Set interface multiplicity on the 'ndbgeneral' library, so that linking
    of executables are not dependent on the order of libraries linked.
    
    Limit memory used by javac. Pushbuild showed several of these in parallel:
    pb2user  54281  0.3  0.0 40029084 71080 pts/1  Sl   13:15   0:06 /usr/local/java/jdk1.8-64/bin/javac
    and the build failed.
    
    Remove a simple FILE(GLOB ...) which had only one result.
    With globbing cmake cannot track dependencies, and dependent targets
    are not rebuilt when source input changes.
    
    TODO: remove all the other globbing in use to find .java sources.
    
    Change-Id: I6ea4a8c8c094ab629b904d1fb44002827641f6b9
Loading