Skip to content
  • Marko Mäkelä's avatar
    f5bbcb19
    Bug#21801423 INNODB REDO LOG DOES NOT INDICATE WHEN FILES ARE CREATED · f5bbcb19
    Marko Mäkelä authored
    
    
    As part of WL#7142 Simplify tablespace discovery during crash recovery,
    InnoDB removed code to deal with the MLOG_FILE_CREATE2 redo log record.
    
    The thinking was that external backup tools could parse MLOG_FILE_NAME
    records to discover created files. However, MLOG_FILE_NAME usually gets
    emitted for something else than file creation, and the MLOG_FILE_CREATE2
    record included some flags that are not present in the MLOG_FILE_NAME
    records.
    
    So, it seems that we must bring back the record, for the benefit of
    external backup tools that parse the redo log.
    
    fil_op_write_log(): Add the parameter "flags" for writing MLOG_FILE_CREATE2.
    
    fil_ibd_create(): Write a MLOG_FILE_CREATE2 record before MLOG_FILE_NAME.
    
    fil_name_parse(): Parse but ignore the MLOG_FILE_CREATE2 record.
    
    RB: 10180
    Reviewed-by: default avatarShaohua Wang <shaohua.wang@oracle.com>
    Reviewed-by: default avatarDebarun Banerjee <debarun.banerjee@oracle.com>
    f5bbcb19
    Bug#21801423 INNODB REDO LOG DOES NOT INDICATE WHEN FILES ARE CREATED
    Marko Mäkelä authored
    
    
    As part of WL#7142 Simplify tablespace discovery during crash recovery,
    InnoDB removed code to deal with the MLOG_FILE_CREATE2 redo log record.
    
    The thinking was that external backup tools could parse MLOG_FILE_NAME
    records to discover created files. However, MLOG_FILE_NAME usually gets
    emitted for something else than file creation, and the MLOG_FILE_CREATE2
    record included some flags that are not present in the MLOG_FILE_NAME
    records.
    
    So, it seems that we must bring back the record, for the benefit of
    external backup tools that parse the redo log.
    
    fil_op_write_log(): Add the parameter "flags" for writing MLOG_FILE_CREATE2.
    
    fil_ibd_create(): Write a MLOG_FILE_CREATE2 record before MLOG_FILE_NAME.
    
    fil_name_parse(): Parse but ignore the MLOG_FILE_CREATE2 record.
    
    RB: 10180
    Reviewed-by: default avatarShaohua Wang <shaohua.wang@oracle.com>
    Reviewed-by: default avatarDebarun Banerjee <debarun.banerjee@oracle.com>
Loading