-
Rahul Sisondia authored
Root cause: ---------- - WL#12098 introduced partial revokes feature which is controlled through the system variable --partial-revokes. This variables remains OFF by default. - We want this feature to be turned ON for certain builds while keeping the value default for rest of the builds. This will ensure better test coverage. Fix: ---- - A new boolean CMAKE build flag PARTIAL_REVOKES_DEFAULT is added. The default value of this flag will remain OFF. - This CMAKE flag is enabled for specific builds in push build system. - As it has been decided that wildcard grants are not supported when partial_revokes is ON. As a result, we now do string comparison in following methods when partial_revokes is ON otherwise we do usual wildcard comparison - acl_getroot() - acl_get() - Security_context::db_acl() - Removed the code that was added during WL#12098 for incompatibility checks of wildcard grants with partial_revokes ON. - Partial revokes is disabled for replication tests that call mysqlbinlog utility and execute the GRANT statements. This change could be reverted once WL#12820 is pushed. Testing: ======= mysql-trunk-stage : ----------------- - push id : 14360366 - Timestamp : 2019-02-18 12:20:57 Review: RB#21264
Rahul Sisondia authoredRoot cause: ---------- - WL#12098 introduced partial revokes feature which is controlled through the system variable --partial-revokes. This variables remains OFF by default. - We want this feature to be turned ON for certain builds while keeping the value default for rest of the builds. This will ensure better test coverage. Fix: ---- - A new boolean CMAKE build flag PARTIAL_REVOKES_DEFAULT is added. The default value of this flag will remain OFF. - This CMAKE flag is enabled for specific builds in push build system. - As it has been decided that wildcard grants are not supported when partial_revokes is ON. As a result, we now do string comparison in following methods when partial_revokes is ON otherwise we do usual wildcard comparison - acl_getroot() - acl_get() - Security_context::db_acl() - Removed the code that was added during WL#12098 for incompatibility checks of wildcard grants with partial_revokes ON. - Partial revokes is disabled for replication tests that call mysqlbinlog utility and execute the GRANT statements. This change could be reverted once WL#12820 is pushed. Testing: ======= mysql-trunk-stage : ----------------- - push id : 14360366 - Timestamp : 2019-02-18 12:20:57 Review: RB#21264
Loading